Fix release attachments being deleted while upgrading #10572
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guillep2k
approved these changes
Mar 2, 2020
GiteaBot
added
the
lgtm/need 1
zeripath
approved these changes
Mar 2, 2020
GiteaBot
added
lgtm/done
jolheiser
approved these changes
Mar 2, 2020
guillep2k
pushed a commit
to guillep2k/gitea
that referenced
this pull request
Mar 2, 2020
guillep2k
pushed a commit
to guillep2k/gitea
that referenced
this pull request
Mar 2, 2020
jolheiser
pushed a commit
that referenced
this pull request
Mar 2, 2020
Co-authored-by: Lunny Xiao <[email protected]>
jolheiser
pushed a commit
that referenced
this pull request
Mar 2, 2020
Co-authored-by: Lunny Xiao <[email protected]>
5 tasks
zeripath
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #10526
When it's iterating, you should not delete anything on the same table. I think it's why the bug occured.
And the old code also just
Cols("uuid")but it deleted the attachement byidbut it's zero. This PR also fixed that.