Skip to content

Conversation

lunny
Copy link
Member

@lunny lunny commented Mar 2, 2020

Fix #10526

When it's iterating, you should not delete anything on the same table. I think it's why the bug occured.

And the old code also just Cols("uuid") but it deleted the attachement by id but it's zero. This PR also fixed that.

@lunny lunny added this to the 1.12.0 milestone Mar 2, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 2, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 2, 2020
@guillep2k guillep2k merged commit 753c067 into go-gitea:master Mar 2, 2020
guillep2k pushed a commit to guillep2k/gitea that referenced this pull request Mar 2, 2020
@lunny lunny deleted the lunny/fix_migrate branch March 2, 2020 15:55
guillep2k pushed a commit to guillep2k/gitea that referenced this pull request Mar 2, 2020
@guillep2k guillep2k added the backport/done All backports for this PR have been created label Mar 2, 2020
jolheiser pushed a commit that referenced this pull request Mar 2, 2020
jolheiser pushed a commit that referenced this pull request Mar 2, 2020
@zeripath zeripath changed the title Fix migration bug on v96.go Fix release attachments being deleted while upgrading Mar 6, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gitea upgrade from 1.9.6 to 1.11.1 drops release attachments
5 participants